// bad
const createArticle = (title, author, date, content) => { }
createArticle('震惊，一男子竟偷偷干这事', 'zhangnan', '2020/06/29', '某天深夜，我喝多了点酒...')

// good
const createArticle = ({title, author, date, content}) => { }
createArticle({
 title: '震惊，一男子竟偷偷干这事'，
 author: 'zhangnan',
 date: '2020/06/29',
 content: '某天深夜，我喝多了点酒...'
})

// bad 代码挤成一堆,很难理清
// 男生女生的通知方式还有所不同，后期如果要改动女生的通知方式，很难保证不会影响到男生
// 因为大家都写在同一个函数里

const notifyStudents = (studentList) => {
 studentList.forEach(student => {
  if (student.gender === 'male') {
   const sender1 = new SmsSender({ carrier: '电信' });
   sender1.init();
   sender1.sendTo(student) 
  } else {
   const sender2 = new SmsSender({ carrier: '联通' });
   sender2.init();
   sender2.sendTo(student);
   
   const sender3 = new EmailSender({ type: 'QQ邮箱' });
   sender3.connect();
   sender3.sendTo(student)
  }
 })
}


// good 函数拆分，各司其职，清晰明了
// 虽然看起来代码量多了一点点
// 但是分工明确，互不影响
const initSmsSender = (carrier) => {
 const sender = new SmsSender({ carrier });
 sender.init();
}

const initEmailSender = (type) => {
 const sender = new EmailSender({ type });
 sender.connect();
}

const notifyMales = (studentList) => {
 const smsSender = initSmsSender('电信');
 const maleList = studentList.filter(student => student.gender === 'male');
 
 maleList.forEach(male => smsSender.sendTo(male));
}

const notifyFemales = (studentList) => {
 const smsSender = initSmsSender('联通');
 const emailSender = initEmailSender('QQ邮箱');
 
 const femaleList = studentList.filter(student => student.gender === 'female');
 
 femaleList.forEach(female => {
  smsSender.sendTo(female);
  emailSender.sendTo(female);
 })
}

// bad
const shouldIBuyThisPhone = (phone) => {
 const {price, year, brand} = phone;
 if (price > 5000 && year === new Date.getFullYear() && brand === 'huawei') {
  // 马上剁手
 }
}

// good
const isHuaweiFlagShipThisYear = ({ price, year, brand }) => {
 const HIGH_PRICE = 5000;
 return price > HIGH_PRICE && year === new Date.getFullYear() && brand === 'huawei'
}

const shouldIBuyThisPhone = (phone) => {
 if (isHuaweiFlagShipThisYear(phone)) {
  // 马上剁手
 }
}

// bad 需要判断标志变量，同时做出不同的相应动作
const print = (person) => {
 if (person === 'A') {
  device.print({ 
   page: 1, 
   color: 'gray', 
   orientation: 'landscape' 
   
  })
 }
 
 else if (person === 'B') {
  device.print({ 
   page: 1, 
   color: 'colorful', 
   orientation: 'vertical' 
  })
 }
 
 else if (person === 'C') {
  device.print({ 
   page: 2, 
   color: 'colorful' ,
   orientation: 'landscape'
  })
 }
 
 ......
 
}


// good
const print = (config) => {
 device.print(config)
}